[build-tools] Support individual ASC API keys in upload_to_asc - #4247
Draft
sswrk wants to merge 1 commit into
Draft
[build-tools] Support individual ASC API keys in upload_to_asc#4247sswrk wants to merge 1 commit into
sswrk wants to merge 1 commit into
Conversation
sswrk
force-pushed
the
szymonswierk/eng-21475-build-tools-upload-to-asc-individual-keys
branch
from
August 21, 2026 17:17
691fdf7 to
d5e280f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4247 +/- ##
==========================================
+ Coverage 64.41% 64.41% +0.01%
==========================================
Files 1048 1048
Lines 48425 48428 +3
Branches 10203 10205 +2
==========================================
+ Hits 31188 31192 +4
+ Misses 17121 17120 -1
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sswrk
force-pushed
the
szymonswierk/eng-21475-build-tools-upload-to-asc-individual-keys
branch
from
August 28, 2026 14:02
d5e280f to
d9ccc69
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASC submissions don't need a team API key. Individual key works too.
The
eas/upload-to-ascfunction requiresissuer_idin the API key json currently.How
issuer_idoptional in the zod schema for the API key ineas/upload-to-asc.issuer_idnullish,issis not set during the token creation, butsubis set touserinstead.Test Plan
CI passes.